Fixes a bug where string equality matches could be manipulated by reg…

…ex metacharacters
geddy · Jul 1, 2013 · b9d5daf · b9d5daf
1 parent 31af941
commit b9d5daf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/adapters/mongo/index.js b/lib/adapters/mongo/index.js
@@ -107,6 +107,7 @@ utils.mixin(Adapter.prototype, new (function () {
         // Case-insensitive equality via regex
         if (nocase) {
           val = val.toLowerCase();
+          val = utils.string.escapeRegExpChars(val);
           re = new RegExp('^' + val + '$', 'i');
           ret[comp.field] = re;
         }

diff --git a/test/integration/adapters/shared.js b/test/integration/adapters/shared.js
@@ -174,6 +174,16 @@ tests = {
     });
   }
 
+, 'test all, by string with metacharacters equality': function (next) {
+    Zooby.all({foo: '.*'}, {nocase:true}, function (err, data) {
+      if (err) {
+        throw err;
+      }
+      assert.equal(0, data.length);
+      next();
+    });
+  }
+
 , 'test all, by string case-insensitive bool': function (next) {
     Zooby.all({foo:'BAR'}, {nocase: true}, function (err, data) {
       if (err) {