Refactor the legend into an ipywidgets subclass #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarcia525
force-pushed
the
colorbar-refactor
branch
from
e3a29c2
to
98009af
Compare
|
Resolved the conflict after merging #1717 |
giswqs
approved these changes
Sep 24, 2023
|
@jgarcia525 Looks great! I have tested it and everything seems working properly. I made some minor changes to provide backward compatability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Will be adding more tests for success cases in upcoming pull request
Co-authored-by: Qiusheng Wu giswqs@gmail.com