Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer management issues #1740

Merged
merged 4 commits into from Sep 28, 2023
Merged

Fix layer management issues #1740

merged 4 commits into from Sep 28, 2023

Conversation

naschmitz
Copy link
Collaborator

There were some issues Qiusheng and I noticed while testing:

  • Toggle all visibility on/off didn't update layer checkboxes
  • Removing a layer didn't reflect in the layer manager
  • Swapping/shuffling layers didn't reflect in the layer manager

These should all be fixed now.

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request September 28, 2023 04:50 Inactive
@giswqs
Copy link
Member

giswqs commented Sep 28, 2023

Thank you for fixing it so quickly. I wondered if the basemap should also be turned off when the All layers off is checked. One use case would be when the data layer only covers a small part of the part and the user only wants to show the data layer without the basemap in the background. With the current setting, the basemap is always shown. Although it can be turned of setting m.layers[0].visible=False, maybe the toggle button should support this as well.

image

@giswqs
Copy link
Member

giswqs commented Sep 28, 2023

I pushed a commit that allows the basemap layer to be toggled off. We can revert it if there a strong opinion again this.

@giswqs giswqs merged commit 15abfb2 into master Sep 28, 2023
8 of 13 checks passed
@giswqs giswqs deleted the nschmitz-layer-manager branch September 28, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants