more notebook fixes #1752
Merged
more notebook fixes #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use consistent quotations sign vector source fixes for 58_add_vector.ipynb
giswqs
approved these changes
Oct 4, 2023
docs/notebooks/58_add_vector.ipynb
Outdated
Comment on lines
133
to
139
| "!mkdir countries_shp\n", | ||
| "!cd countries_shp && \\\n", | ||
| "wget https://raw.githubusercontent.com/gee-community/geemap/master/examples/data/countries.shp && \\\n", | ||
| "wget https://raw.githubusercontent.com/gee-community/geemap/master/examples/data/countries.cpg && \\\n", | ||
| "wget https://raw.githubusercontent.com/gee-community/geemap/master/examples/data/countries.dbf && \\\n", | ||
| "wget https://raw.githubusercontent.com/gee-community/geemap/master/examples/data/countries.prj && \\\n", | ||
| "wget https://raw.githubusercontent.com/gee-community/geemap/master/examples/data/countries.shx" |
There was a problem hiding this comment.
Using wget is discouraged as it only supports Linux/Mac. Windows users won't be able to use this.
I suggest changing to this:
url = "https://raw.githubusercontent.com/gee-community/geemap/master/examples/data/countries.zip"
geemap.download_file(url)There was a problem hiding this comment.
The download_file() function will download the zip file and unzip it automatically.
There was a problem hiding this comment.
Thank you for correcting that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use consistent quotations sign
vector source fixes for 58_add_vector.ipynb