New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor visual bug fixes #1754
Minor visual bug fixes #1754
Conversation
🚀 Deployed on https://651cdf562b96d6746c9f35b6--opengeos.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I had one comment regarding window.open
patterns.
Should we make the basemap layer show up on the layer manager? Right now, the basemap is always shown and can't be toggled off. This is not ideal because sometime users just want to show some EE layers for a small non-rectangular region without basemap in the background. Peek.2023-10-03.22-35.mp4 |
Is it alright if we address this in a future PR? I think the best solution is to include the basemap in the layer manager, but it doesn't seem like a launch-blocking issue. |
I have included the basemap in the layer manger. Only one line of code needs to be changed. The only minor issue is that the basemap name If you are OK with that, I can commit the changes. Or do we want the rename the default basemap from Peek.2023-10-03.22-52.mp4 |
I think it's fine if the three dots show up. Thanks Qiusheng! |
You'll need to update the unit test too. |
I am looking into the unit tests now. Will fix it shortly. |
The bug fixes are as follows: