[core] Fix get_bounds behavior in core #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - added alias for getBounds, - fixed an issue where geemap crashed without a helpful message if the map hadn't been added to the screen, and - added some unit tests. The behavior was correct in geemap non-core.
for more information, see https://pre-commit.ci
naschmitz
changed the title
giswqs
approved these changes
Jun 14, 2024
geemap/core.py
Outdated
| @@ -488,9 +488,29 @@ def set_zoom(self, value: int) -> None: | |||
| def get_center(self) -> Sequence: | |||
| return self.center | |||
|
|
|||
| def get_bounds(self) -> Sequence: | |||
| def get_bounds(self, as_geo_json: bool = False) -> Sequence: | |||
There was a problem hiding this comment.
Should we change as_geo_json to as_geojson?
geemap/core.py
Outdated
| # https://ipyleaflet.readthedocs.io/en/latest/map_and_basemaps/map.html#ipyleaflet.Map.fit_bounds | ||
| coords = [bounds[0][1], bounds[0][0], bounds[1][1], bounds[1][0]] | ||
|
|
||
| if as_geo_json: |
| return coords | ||
|
|
||
| getBounds = get_bounds | ||
| return super().get_bounds(as_geo_json=asGeoJSON) |
tests/test_core.py
Outdated
|
|
||
| mock_bounds.__get__ = Mock(return_value=()) | ||
| with self.assertRaisesRegex(RuntimeError, "Map bounds are undefined"): | ||
| self.core_map.get_bounds(as_geo_json=True) |
geemap/core.py
Outdated
| """Returns the bounds of the current map view. | ||
|
|
||
| Args: | ||
| as_geo_json (bool, optional): If true, returns map bounds as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
The behavior was correct in geemap non-core.