Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateRange is also class created upon init #206

Closed
12rambau opened this issue Feb 5, 2024 · 1 comment · Fixed by #209 or #213
Closed

DateRange is also class created upon init #206

12rambau opened this issue Feb 5, 2024 · 1 comment · Fixed by #209 or #213
Labels
impact: high Something that is relevant to nearly all users kind: bug Something isn't working

Comments

@12rambau
Copy link
Member

12rambau commented Feb 5, 2024

When trying to import geetools within an environment that is using earthengine-api < 0.1.388 DateRange is created upon init instead of being define from scratch.

THe consequence is that we get the following error:

.nox/test/lib/python3.9/site-packages/geetools/DateRange/init.py:10: in
@register_class_accessor(ee.DateRange, "geetools")
E AttributeError: module 'ee' has no attribute 'DateRange'

You cna check looking at this file in the API source code: https://github.com/google/earthengine-api/blame/cdfe00b9d862fa753d647c2788d7d0f4a56bb647/python/ee/daterange.py
@12rambau 12rambau added impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working impact: high Something that is relevant to nearly all users and removed impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship labels Feb 5, 2024
@12rambau 12rambau mentioned this issue Feb 5, 2024
Merged
@12rambau
Copy link
Member Author

12rambau commented Feb 7, 2024

It is still very much a problem as it is still imported in Init file

@12rambau 12rambau reopened this Feb 7, 2024
12rambau added a commit that referenced this issue Feb 7, 2024
@12rambau
fix: remove DateRangeAccessor from init
269dfc1 
I guess the addition was made during a conflicting merge. 

Fix #206 again
@12rambau 12rambau mentioned this issue Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: high Something that is relevant to nearly all users kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@12rambau