Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve accessor implementation #193

Merged
merged 4 commits into from Feb 4, 2024
Merged

refactor: improve accessor implementation #193

merged 4 commits into from Feb 4, 2024

Conversation

12rambau
Copy link
Member

@12rambau 12rambau commented Feb 4, 2024

Fix #191
Fix #189

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (5da5b6d) 36.41% compared to head (d7da3da) 36.52%.

Files Patch % Lines
geetools/Initialize/__init__.py 46.15% 14 Missing ⚠️
geetools/Authenticate/__init__.py 66.66% 5 Missing ⚠️
geetools/accessors.py 76.47% 2 Missing and 2 partials ⚠️
geetools/ComputedObject/__init__.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   36.41%   36.52%   +0.10%     
==========================================
  Files          53       52       -1     
  Lines        2908     2927      +19     
  Branches      291      296       +5     
==========================================
+ Hits         1059     1069      +10     
- Misses       1846     1853       +7     
- Partials        3        5       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@12rambau 12rambau merged commit bf082d3 into main Feb 4, 2024
11 checks passed
@12rambau 12rambau deleted the accessor branch February 4, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend Initialize and Authenticate sanitize the accessor registration
1 participant