Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the docs link #575

Merged
merged 1 commit into from Dec 21, 2023
Merged

update the docs link #575

merged 1 commit into from Dec 21, 2023

Conversation

shenchucheng
Copy link
Collaborator

No description provided.

@garylin2099
Copy link
Collaborator

readme里挂最新的stable（v0.5）是否更合适。觉得每次更改可以向v0.x-release提，后续合入main。此外，这里还需修改README_JA.md

@shenchucheng
Copy link
Collaborator Author

我觉得main分支应该是要对应main分支的docs，因为main分支本身就是unstable，我们在开发的过程中，main文档可能会异步更新，但是如果是对应0.5，那就一定是没有更新的了。不过文档站默认显示stable版本，我觉得是合理的

@shenchucheng
Copy link
Collaborator Author

shenchucheng commented Dec 17, 2023 •
edited

@garylin2099 另外，我觉得尽量不要从release合入到main，一般release后，如果需要修复release和main，用cherry-pick会更合适

@garylin2099
Copy link
Collaborator

@garylin2099 另外，我觉得尽量不要从release合入到main，一般release后，如果需要修复release和main，用cherry-pick会更合适

结论：当前场景不复杂，merge即可。有特殊情况可cherry-pick。LGTM

@geekan
Copy link
Owner

geekan commented Dec 21, 2023

LGTM

@geekan geekan merged commit b8b584e into geekan:main Dec 21, 2023
This was referenced Dec 21, 2023
Closed
Closed
Closed
@shenchucheng shenchucheng deleted the fix-docs-link-error branch December 28, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shenchucheng @garylin2099 @geekan