Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adiciona PIS/PASEP #106

Closed
wants to merge 1 commit into from
Closed

Conversation

omarkdev
Copy link
Contributor

@omarkdev omarkdev commented Nov 8, 2020

No description provided.

@geekcom
Copy link
Owner

geekcom commented Nov 12, 2020

Muito bom, como sempre código de qualidade, obrigado @omarkdev, so faltou um pequeno detalhe: adicionar a mensagem em caso de erro em: src/validator-docs/ValidatorProvider@getMessages()

Outro ponto e que temos essa validacao, embora ela seja para PIS/PASEP/NIT/NIS:

$this->validate($request, [
    'nis' => 'required|nis',
]);

src/validator-docs/Rules/Nis.php

@omarkdev
Copy link
Contributor Author

Certo @geekcom, então no caso essa feature não será necessária? Já que existe o nis ?

@geekcom
Copy link
Owner

geekcom commented Nov 12, 2020

Acredito que validação que existe cobre o PIS/PASEP tranquilo.

@omarkdev
Copy link
Contributor Author

@geekcom

Ahh ok, não tinha visto direito, foi mal! Haha

Vou fechar este PR então.

@omarkdev omarkdev closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants