Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements at the crap helper class (no pun intended) #6

Merged
merged 2 commits into from
Feb 20, 2017
Merged

Minor improvements at the crap helper class (no pun intended) #6

merged 2 commits into from
Feb 20, 2017

Conversation

flyingluscas
Copy link
Contributor

Description

  1. Converting to boolean the return of the method validateAlias, avoiding the ternary condition.
  2. Using array_map function to parse the arguments, that way we get rid of the foreach and the $require.

Motivation and context

Since the parseArguments method is mutating an array of arguments, I believe that the array_map function is the perfect solution for this case.

Thanks for making such a cool library :D

@coveralls
Copy link

coveralls commented Feb 19, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 1b044b0 on flyingluscas:improvement/refactoring-crap-helper into a3f3cb1 on geekish:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1b044b0 on flyingluscas:improvement/refactoring-crap-helper into a3f3cb1 on geekish:master.

@geekish geekish merged commit 72c8475 into geekish:master Feb 20, 2017
@geekish
Copy link
Owner

geekish commented Feb 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants