Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow table not updated with workflow state #212

Closed
imegory opened this issue Feb 12, 2019 · 3 comments
Closed

Workflow table not updated with workflow state #212

imegory opened this issue Feb 12, 2019 · 3 comments

Comments

@imegory
Copy link

imegory commented Feb 12, 2019

Today, I re-bundled all my gems (in Gemfile), ran the specs, and one spec failed. It appears that the workflow db table was not updated with the new workflow state. I know that the failing spec used to pass about 1-2 months ago. Anyways, I did override load_workflow_state, and persist_workflow_state methods and then the failing spec passed.

FYI: I am on rails 5.2.1 and my test was using workflow 2.0. I tried following the instructions that suggested to use the active-record gem. In my experience that does not work.

Anyways, just sharing my experience.

@geekq
Copy link
Owner

geekq commented Feb 15, 2019

Thanks @imegory, your feedback on using/bundling the new workflow 2.0 and workflow-activerecord is important!

Can you please provide a minimal example to reproduce the problem?
Or tell, what do you do differently compared to the minimal sample application
https://github.com/geekq/workflow-rails-sample/blob/master/Gemfile#L40-L41
https://github.com/geekq/workflow-rails-sample/blob/master/app/models/article.rb#L4 ?

Tests using workflow-activerecord 4.1.2, workflow 2.0.0 and activerecord 5.2.2 also run successfully:
https://travis-ci.org/geekq/workflow-activerecord/jobs/478725932
Please tell, if you think anything is missing in the persistence test https://github.com/geekq/workflow-activerecord/blob/develop/test/persistence_test.rb

@imegory
Copy link
Author

imegory commented Feb 15, 2019 via email

@geekq
Copy link
Owner

geekq commented Apr 4, 2019

Closing due inactivity. Please feel free to reopen the issue if you have new information

@geekq geekq closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants