Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events availability methods #210

Closed
wants to merge 1 commit into from
Closed

Add events availability methods #210

wants to merge 1 commit into from

Conversation

dapi
Copy link

@dapi dapi commented Jan 11, 2019

No description provided.

@geekq
Copy link
Owner

geekq commented Jan 12, 2019

Thanks for your contribution! Please note, that workflow lib is currently under
heavy refactoring preparing for the 2.0 release where ActiveRecord support is
extracted into a separate gem. Once 2.0 is released, we can work on integrating
your extension.

What I can already see:

  • Note about motivation for this extension would be helpful! (what this feature can be used for?)
    Like "showing buttons in the GUI for all the available transitions"?
  • It can be also provided as a unit test - unit tests covering the change are required anyway
  • both functions have got very similar implementation - probably merge them into one,
    if state parameter is not provided - use the current state

@geekq geekq closed this Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants