New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest merger fails when assembling Android test application #777
Comments
Running into this, as well. |
@sonicdoe Are you using buildType = "debug"
|
No, the example project at |
I'm running into this as well - a random google search showed this issue crosswalk-project/cordova-plugin-crosswalk-webview#207 which suggests using buildToolsVersion: 28.0.0. We already do this, but then I noticed a warning during build
OneSignalPlugin: WARNING: OneSignalPlugin: Downgraded 'com.android.support:28.0.0' -> 27.+ to prevent compile errors! Recommend updating your project's compileSdkVersion!
where this project is forcing it to downgrade ;( |
My personal issue was resolved when I built using the proper FWIW, here is part of my
|
Thanks for your patience while we investigate the issue. |
Howdy y'all, We also realized we were running into issues with Thanks for bringing this to our attention. |
I was able to get Unfortunately, I couldn’t get to the bottom of why this issue occurs and why these changes are necessary. As far as I could find out, @rgomezp Let me know if you have any more insight and whether the above changes would be okay. If so, I’d open a pull request. |
@rgomezp adding my question here since you closed the other ticket is this directory necessary to be included in the npm package or can it only live in the GitHub repo? Because if the answer is no, then this problem is solved for me. I'm asking because I don't know what are good practices but I don't see other RN packages with this directory androidTest so I guess either nobody is testing or they don't include tests in the npm package? |
@mtt87 , |
Fantastic 😄 Thank you |
Howdy y'all,
Would love to hear your feedback prior to the release. Cheers! EDIT: IGNORE THESE INSTRUCTIONS AS THE PLUGIN HAS BEEN PUSHED TO NPM |
I see you’ve already released the newest version, v3.3.0. Should this release change anything about this issue? If I repeat the reproduction steps from the original post, I’m running into the exact same error. |
Description
When assembling the Android test application using
./gradlew assembleAndroidTest
, the manifest merger fails with the following errors:A similar issue was reported with #579 in July 2018 and subsequently closed in January 2019 without any apparent resolution.
Environment
The example project at
examples/RNOneSignal@31b5242
which uses react-native-onesignal v3.2.14.Steps to reproduce
git clone https://github.com/geektimecoil/react-native-onesignal.git
cd react-native-onesignal
git checkout 31b52420c807c22405e70b44800e20f3a8e3456e
cd examples/RNOneSignal
yarn
cd android
./gradlew assembleAndroidTest
The text was updated successfully, but these errors were encountered: