Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to account creation #30

Closed
CarwynNelson opened this issue Jul 24, 2020 · 5 comments · Fixed by #42
Closed

Improvements to account creation #30

CarwynNelson opened this issue Jul 24, 2020 · 5 comments · Fixed by #42
Assignees

Comments

@CarwynNelson
Copy link
Contributor

  • Password strength checking
  • Throttling of login attempts
@jamesgeddes
Copy link
Contributor

Is django-password-strength of any use?

Also, (future improvement) this would be a great place to include the Geek.Zone affiliate link to LastPass

@jamesgeddes
Copy link
Contributor

jamesgeddes commented Oct 3, 2020

I'd argue that password length is more important than complexity, see

I do agree that login throttling, 3 bad login attempts every hour for example, is a good idea. We could combine this with an email to the account holder, something like, "Someone just tried, and failed, to log into your Geek.Zone account. Your account is safe, however just to be sure you might like to change your password."

@jamesgeddes
Copy link
Contributor

Would recaptcha be a better first step than blindly throttling? I've created keys for geek.zone, where should I put them?

@jamesgeddes
Copy link
Contributor

Split to #43

@jamesgeddes jamesgeddes linked a pull request Oct 3, 2020 that will close this issue
@jamesgeddes
Copy link
Contributor

jamesgeddes commented Oct 3, 2020

@CarwynNelson and I have agreed that we will change the password length to 9. Should ideally use the built in methods to check for common passwords. Post MVP we could have a password strength indicator that only goes fully green after 16 characters.

@jamesgeddes jamesgeddes self-assigned this Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants