add support for email confirmation #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to send appropriate PR to https://github.com/Jessecar96/SteamDesktopAuthenticator after(if) this PR will be merged. |
dyc3
approved these changes
Oct 6, 2019
This was referenced Oct 27, 2019
Rudokhvist
force-pushed
the
emailconfirmation
branch
from
0e73fb1
to
ae630b6
Compare
dyc3
approved these changes
Nov 16, 2019
SteamAuth/AuthenticatorLinker.cs
Outdated
Comment on lines
56
to
66
| if (!hasPhone) { | ||
| if (confirmationEmailSent) { | ||
| if (!_checkEmailConfirmation()) { | ||
| return LinkResult.GeneralFailure; | ||
| } | ||
| } else if (!_addPhoneNumber()) { | ||
| return LinkResult.GeneralFailure; | ||
| } else { | ||
| confirmationEmailSent = true; | ||
| return LinkResult.MustConfirmEmail; | ||
| } |
There was a problem hiding this comment.
Not a huge issue, but you are using tabs to indent, which is inconsistent with the rest of the file which uses spaces.
There was a problem hiding this comment.
Thank you, fixed it.
|
How can i access this ? |
|
@Burnwithme access what exactly? |
|
Is there an edited and ready to use version? |
|
@Burnwithme if you need fixed SteamDesktopAuthenticator - you can use my fork from here https://github.com/Ryzhehvost/SteamDesktopAuthenticator/releases/latest for now. If you need just library - you can clone my repo https://github.com/Ryzhehvost/SteamAuth for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently steam changed procedure of adding authenticator - now before adding phone number it's required to confirm email once more. This PR adds support for this step.