Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Jspm 0.16 Compatibility #27

Merged
merged 2 commits into from Sep 24, 2015
Merged

Conversation

johnraz
Copy link
Contributor

@johnraz johnraz commented Aug 28, 2015

Hot reloading of regular es6 module seems ok, jsx is broken and I have so far no idea why ^^

@johnraz
Copy link
Contributor Author

johnraz commented Aug 28, 2015

ok I just realized that #25 is solving about the same issue but I don't believe JSX is fixed there either.

@Globegitter did you test jsx hot reloading ?

@johnraz johnraz changed the title [WIP] Fix the path resolution, hot-reloading of jsx module is broken so far [WIP] Jspm 0.16 Compatibility Aug 30, 2015
I was able to go around this issue by setting:
```
...
  packages: {
      "lib/components/": {
        "defaultExtension": "jsx",
      }
  }
...
```
in my config.js
@johnraz
Copy link
Contributor Author

johnraz commented Aug 30, 2015

Further investigation regarding jsx showed that using it as regular javascript file, without any loader, actually made hot reloading work for react component.

I'm not sure if the state is persisted, didn't try yet, and my guess would be no, as no react hot api is used now...

I really need to dig this further at several level:

  • I need to better understand how react-hot-api is and should be used.
  • I need to better understand how systemjs uses plugins and loaders and how the actual jsx-loader is working.

If anybody has information about these topic, that would be nice :-)

@johnraz
Copy link
Contributor Author

johnraz commented Aug 30, 2015

Ok as expected, the state is not persisted.

Gently pinging @geelen and @guybedford for ideas on keeping this working.

@guybedford
Copy link

@johnraz I haven't followed this work too closely, but if you have any specific questions I'm happy to answer them.

@johnraz
Copy link
Contributor Author

johnraz commented Sep 17, 2015

ok back to business after a sweet trip, still have some days off at home \o/

@guybedford, I do have 1 specific request:

Could you give a look at https://github.com/johnraz/jspm-server/blob/jspm-0.16-compatibility/lib/change-handler.js and review the usage of systemJS there ? I want to make sure there is no better way to do that part with the latest systemJS api.

Thx !

@johnraz johnraz mentioned this pull request Sep 17, 2015
geelen added a commit that referenced this pull request Sep 24, 2015
@geelen geelen merged commit 8bd9534 into geelen:master Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants