Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for apache_listen_port_ssl for Debian, RedHat, Suse and AmazonLinux. #150

Closed
wants to merge 1 commit into from
Closed

Add support for apache_listen_port_ssl for Debian, RedHat, Suse and AmazonLinux. #150

wants to merge 1 commit into from

Conversation

tobias-richter
Copy link

This PR will add support for apache_listen_port_ssl for Debian, RedHat, Suse and Amazon Linux as this is currently not implemented.
I have to admit that the regular expressions are quite complex. One solution to simplify them would be to create os family and apache version specific var files.

Changes:

Apache Listen Port

  • Removed apache_ports_configuration_items from os family vars since they are overwritten by the apache vars anyways
  • Kept line in file mechanism in order to be backward compatibel
  • Added new regexp mechanism to apply changes to the configuration files
  • Added regex for apache 2.2 and apache 2.4 in order to set apache_listen_port and apache_listen_port_ssl

Apache Modules

  • Switched enabling and enabling of apache mods to ansible apache2_module
    ** Old .load syntax for apache_mods_enabled andapache_mods_disabled is still supported
  • Added apache module enabling / disabling for RedHat/Amazon Linux and Suse

Amazon Linux

  • Updated __apache_packages since configured packages were not found during testing

Tested on:

  • Debian 7
  • Debian 8
  • Debian 9
  • CentOS 6
  • CentOS 7
  • SLES 12.3
  • OpenSuse 42.2
  • OpenSuse 42.3
  • Solaris 11
  • Amazon Linux 2016.03
  • Amazon Linux 2016.09
  • Amazon Linux 2017.03

The tests from tests/ have also passed for

  • CentOS 6
  • CentOS 7
  • Ubuntu 1804
  • Ubuntu 1604
  • Ubuntu 1204
  • Ubuntu Debian 9
  • Ubuntu Debian 8

@stale
Copy link

stale bot commented Mar 6, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant