-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vhosts extra_parameters indentation #195
Fix vhosts extra_parameters indentation #195
Conversation
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
The indentation issue is still here. |
Not that I can see - shame the stale bot closed it before review |
Indeed, I can understand the usage of a stale bot for the issues but for MRs it discourages people from submitting ! |
@geerlingguy are you able to review? |
This pull request is no longer marked for closure. |
Letting tests run on it again. Sorry about that—issues like this are issues I do want to merge (they fix actual bugs/broken-ish functionality in the role), but sometimes they seemingly get lost in the barrage. |
Uses the indent Jinja filter to ensure that all lines of the extra_parameters variable are indented to the same level (2 to match the rest of the vhosts template)
Example playbook snippet:
Would previously produce this output:
With this change the output is:
I added
first
andindentfirst
keyword arguments to cover all bases (indentfirst
was renamed tofirst
in Jinja 2.10).