APT key: don't force and provide checksum, to fix check mode #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerlingguy
requested changes
Jun 15, 2023
As described in ansible/ansible#65687, get_url only partially supports check_mode: "the changed status will reflect comparison to an empty source file". Before this change, executing this code, with the key already being in place on the target system, would report "OK", while check_mode would report "changed". Due to this change, both now either report "OK" or "changed", depending on the state of the target system.
nevart
force-pushed
the
apt-key-fix-check-mode
branch
from
fffda2c
to
7c86fe1
Compare
|
@geerlingguy Anything I may do to get this merged? |
geerlingguy
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in ansible/ansible#65687, get_url only partially supports check_mode: "the changed status will reflect comparison to an empty source file".
Before this change, executing this code, with the key already being in place on the target system, would report "OK", while check_mode would report "changed".
Due to this change, both now either report "OK" or "changed", depending on the state of the target system.