Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add configuration to use https rather than git:// native git addressing (to port 9148) #3

Closed
danryu opened this issue May 22, 2015 · 4 comments
Labels

Comments

@danryu
Copy link

danryu commented May 22, 2015

This is a single line change which will allow all those working in typically restrictive corporate networks to access all git repos current inaccessible on port 9148.
This is what I adopted in my forked repo at https://github.com/danryu/ansible-role-git/blob/master/tasks/main.yml#L17

- name: configure git to use https and not native git protocol
  command: git config --global url."https://".insteadOf "git://"

and it works well in testing. Previous multi-hour hangs caused by composer trying to build drush by referencing dozens of github repos via git:// addresses are now avoided successfully.

Background provided in debugging outlined in geerlingguy/drupal-vm#101

@geerlingguy
Copy link
Owner

This seems like a good improvement—but I'll leave it as a configurable option (e.g. using when: git_use_https_instead_of_git_protocol) so users can stick to git:///other protocols by default, and configure https if needed.

@danryu
Copy link
Author

danryu commented May 22, 2015

This seems fair :-)

@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

@stale stale bot closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants