Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Remove optional postfix dependency #117

Closed
wants to merge 1 commit into from
Closed

Remove optional postfix dependency #117

wants to merge 1 commit into from

Conversation

evilhamsterman
Copy link

@geerlingguy This is the same idea as #86 but simpler, there's no need to make the dependencies a variable because there are just ones listed by Gitlab as necessary. But as stated in #86 postfix is optional and your role doesn't configure it. Since Gitlab can use direct SMTP or another sendmail option that should just simply be left to the users playbook to configure. If the need other dependencies then those should be other roles or part of the playbook.

I'm in the same situation as the guy in #86 we use nullmailer and have a role defined which sets it up and this role conflicts right now.

@stale
Copy link

stale bot commented May 21, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label May 21, 2020
@eRadical
Copy link

This should be still active.

@stale
Copy link

stale bot commented May 21, 2020

This issue is no longer marked for closure.

@stale stale bot removed the stale label May 21, 2020
@geerlingguy
Copy link
Owner

It is now possible (after dfdfa1f) to override the gitlab_dependencies list and swap postfix for exim (or remove it and depend on something else entirely).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants