Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to copy custom init.d scripts. #159

Closed

Conversation

sebastianludwig
Copy link
Contributor

As discussed in #151 I added a parameter to copy custom init.d scripts to Jenkins.

@sebastianludwig
Copy link
Contributor Author

@geerlingguy Not "All checks have failed", one test got stuck installing Java. The added test succeeded. Can you trigger Travis again?

@sebastianludwig
Copy link
Contributor Author

Never mind, I forgot to update the README. This time all checks passed 🎉

@sebastianludwig
Copy link
Contributor Author

@geerlingguy is anything missing I can do?

tests/test-initd-scripts.yml Outdated Show resolved Hide resolved
@sebastianludwig
Copy link
Contributor Author

@geerlingguy sorry that it took so long but I finally got around to add a real script to the test case. Anything else you'd like to have changed?

@jgerry
Copy link

jgerry commented Apr 5, 2018

I tried this PR today as it's something I need - works great! Merge away. I also added another option like this to manually install .hpi files for private plugins. My job requires our private pre-configured Okta plugin which needed this.

@nickbroon
Copy link
Contributor

nickbroon commented Apr 4, 2019

This is definitely very useful, and I'd love to see it merged.
It's specifically for the example case of starting jenkins in quiet mode that I'd like to use it.
https://wiki.jenkins.io/display/JENKINS/Post-initialization+script documents this.

@nickbroon
Copy link
Contributor

@sebastianludwig can all changes requested (to add a test case) now be marked resolved?
https://help.github.com/en/articles/about-pull-request-reviews#resolving-conversations

@geerlingguy are you happy to now merge this PR?

@stale
Copy link

stale bot commented Mar 6, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants