-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow replica master to be differ from local inventory + fix Is_Replica or Is_Slave #503
Conversation
I have upgraded some dependencies in my dev environment (MariaDB) and my slave data from getreplica is now
but the current check is |
Well that was a quick merge! Cheers |
Hey @giorgioma, I'm just wonder if there's a reason the task: I notice the logic of that Edit: what I mean when I say the logic of the |
@hahayusuf I think what's wrong with it is mentioned in my edit. I changed the - (slave.Is_Slave is defined and slave.Is_Slave) or (slave.Is_Replica is defined and slave.Is_Replica) or (slave.Is_Slave is not defined and slave.Is_Replica is not defined and slave is failed) |
Ah yes! I was informed i broke my staging env as well, i'll open a pr in the morning |
@giorgioma No worries, I created #511. Would you mind trying that out and seeing if it works for you? |
E.g.
I am running ansible on my local machine and they are accessible over public IP but i want the master and the slave to communicate over some other network interface card.
mysql_replication_master_inventory_host
defaults tomysql_replication_master
so it's a non-breaking change