Skip to content

Commit

Permalink
Fixes #26: Remove nodejs_forever default installation.
Browse files Browse the repository at this point in the history
  • Loading branch information
geerlingguy committed Apr 22, 2016
1 parent 1423626 commit d985c52
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 23 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Expand Up @@ -51,7 +51,6 @@ script:
- 'sudo docker exec --tty "$(cat ${container_id})" env TERM=xterm node -v'

# Ensure npm packages are installed globally.
- 'sudo docker exec --tty "$(cat ${container_id})" env TERM=xterm npm list -g --depth=0 forever'
- 'sudo docker exec --tty "$(cat ${container_id})" env TERM=xterm npm list -g --depth=0 jslint'
- 'sudo docker exec --tty "$(cat ${container_id})" env TERM=xterm npm list -g --depth=0 node-sass'
- 'sudo docker exec --tty "$(cat ${container_id})" env TERM=xterm npm list -g --depth=0 yo'
Expand Down
5 changes: 0 additions & 5 deletions README.md
Expand Up @@ -20,10 +20,6 @@ The Node.js version to install. "0.10" is the default and works on all supported

The user for whom the npm packages will be installed can be set here, this defaults to ansible_ssh_user

nodejs_forever: true

Whether to install Forever, a simple process manager for Node.js. With forever installed, you can start a Node.js app with the command `forever start /path/to/app.js`, and manage the app via `forever` much the same as you would manage other services on your server with `service`.

nodejs_npm_global_packages: []

Add a list of npm packages with a `name` and (optional) `version` to be installed globally. For example:
Expand All @@ -49,7 +45,6 @@ None.

*Inside `vars/main.yml`*:

nodejs_forever: true
nodejs_npm_global_packages:
- name: jslint
- name: node-sass
Expand Down
3 changes: 0 additions & 3 deletions defaults/main.yml
Expand Up @@ -6,9 +6,6 @@ nodejs_version: "0.12"
# The user for whom the npm packages will be installed.
# nodejs_install_npm_user: username

# Install forever, which is useful for running Node.js apps.
nodejs_forever: true

# Define a list of global packages to be installed with NPM.
nodejs_npm_global_packages: []
# # Install a specific version of a package.
Expand Down
1 change: 1 addition & 0 deletions meta/main.yml
Expand Up @@ -21,6 +21,7 @@ galaxy_info:
- raring
- saucy
- trusty
- xenial
galaxy_tags:
- development
- web
14 changes: 0 additions & 14 deletions tasks/main.yml
Expand Up @@ -10,20 +10,6 @@
nodejs_install_npm_user: "{{ ansible_ssh_user }}"
when: nodejs_install_npm_user is not defined

# TODO: Remove this task after Ansible 2.x npm module bug is fixed. See:
# https://github.com/ansible/ansible-modules-extras/issues/1375
- name: Ensure forever is installed (to run Node.js apps).
npm: name=forever global=yes state=present
become: yes
become_user: "{{ nodejs_install_npm_user }}"
when: nodejs_forever

- name: Ensure forever is at the latest release.
npm: name=forever global=yes state=latest
become: yes
become_user: "{{ nodejs_install_npm_user }}"
when: nodejs_forever

# TODO: Remove this task after Ansible 2.x npm module bug is fixed. See:
# https://github.com/ansible/ansible-modules-extras/issues/1375
- name: Ensure npm global packages are installed.
Expand Down

0 comments on commit d985c52

Please sign in to comment.