Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REBASED: add support for chrony on EL7 #72

Merged
merged 4 commits into from Mar 26, 2020

Conversation

ogajduse
Copy link
Contributor

This PR is identical with #43 by @selyx but rebased to current master.
This PR should solve #71, most likely solve #22.
If you would choose a different approach, please let me know, I will try to change it.

Copy link

@m8ram m8ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is this change will work for RHEL6 and up but it will break for RHEL 5. Is it possible to use ntp for all ansible_distribution_major_version < '7'?

@ogajduse
Copy link
Contributor Author

@m8ram I am happy to edit these few characters.
@geerlingguy Do you want the role to keep support for RHEL 5?

Official Red Hat's statement about RHEL 5 support:

The end of Extended Life Cycle Support is scheduled for November 30, 2020, for RHEL 5.11.

@geerlingguy
Copy link
Owner

It would be nice to still support RHEL 5, but I wouldn't hold back merging this at some point on that point. Note that I still use ntp on CentOS 7... haven't yet deployed CentOS 8 in production. Can you also add a centos8 test in .travis.yml since that should presumably work with chrony?

@ogajduse
Copy link
Contributor Author

Tests on Centos 8 passed. Error in the Debian run is infrastructure-related.

@geerlingguy geerlingguy merged commit c9e2a45 into geerlingguy:master Mar 26, 2020
geerlingguy added a commit that referenced this pull request Mar 26, 2020
@geerlingguy
Copy link
Owner

I merged this, but changed the way it works so you can still override ntp_package and ntp_config file. Because you can still install and use ntp on CentOS/RHEL 7 it's important to preserve the ability for people to use this role on that OS release.

For those who wish to still use ntp on CentOS 7 instead of chronyd, they can set:

ntp_package: ntp
ntp_config_file: /etc/ntp.conf

And it should work the same as before. However, since defaults are changing, I am releasing a major new version of this role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants