Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly consider php_packages variable when using with geerlingguy.php #39

Closed
wants to merge 2 commits into from

Conversation

aft2d
Copy link

@aft2d aft2d commented May 31, 2019

If php_packages is set on task level like

block:
- include_role:
name: php-versions
- include_role:
name: geerlingguy.php
vars:
php_version: "7.3"
php_versions_install_recommends: false
php_enable_webserver: false
php_packages_state: "present"
php_install_recommends: false
php_enable_php_fpm: false
php_enable_apc: false
php_packages:
- php7.3-common
- php7.3-cli
- php7.3-zip
- php7.3-curl
- php7.3-mbstring

or in a var file etc. the module overwrites php_packages which is used in the geerlingguy.php role.

This PR checks if the variable is set in general and not only on the host level.

@webarchitect609
Copy link
Contributor

@aft2d, thank you for this fix! I used it in my fork webarchitect609.php_versions. Please, feel free to use, if you still need it.

@stale
Copy link

stale bot commented Jul 7, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jul 7, 2020
@stale
Copy link

stale bot commented Aug 6, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants