Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension path is wrong for Debian #15

Merged
merged 1 commit into from
Nov 3, 2014
Merged

Extension path is wrong for Debian #15

merged 1 commit into from
Nov 3, 2014

Conversation

LewisW
Copy link
Contributor

@LewisW LewisW commented Nov 3, 2014

Currently on Debian, the role will put the extension ini files in: /etc/php5/conf.d

This directory is meant to be used to store the ini files, and then they can be symlinked into /etc/php5/apache2/conf.d to enable them. So just putting them there won't actually enable them.

@geerlingguy
Copy link
Owner

Correct me if I'm wrong... but wouldn't this only work for Apache? The role is meant to be as flexible as possible (working with fpm, Nginx, etc.), so I'd rather keep the configuration flexible to suit all those needs... I'm willing to add better support for Apache's model, but frankly I'm not a huge fan of the way Debian/Ubuntu seem to use specialized and annoying directory structures for Apache configuration :)

@LewisW
Copy link
Contributor Author

LewisW commented Nov 3, 2014

Yes, it assumes Apache2. But "php_conf_path" already assumes apache2 so I followed suite of that. My understanding of Ubuntu convention is you're supposed to put config files in /etc/php5/conf.d, and then symlink them into /etc/php5/apache2/conf.d.

I know what you mean about Ubuntu, but unfortunately most of our developers, and the testing platforms we use, are all Ubuntu-based. So it just makes life easier to use Ubuntu, since we don't have a dedicated devops team. It's the main reason I used your roles, so we can switch eventually!

I'm happy to change the PR to do this properly, but could you merge this in the mean time since it's already coupled to apache2?

I'm not a huge fan of apache and would like to switch to nginx, so it's something I was planning on fixing anyway. But again, you have to pick your battles one at a time!

geerlingguy added a commit that referenced this pull request Nov 3, 2014
Extension path is wrong for Debian/Apache2.
@geerlingguy geerlingguy merged commit 1dc9424 into geerlingguy:master Nov 3, 2014
@geerlingguy
Copy link
Owner

Merged, since it is following the role convention for the rest of the PHP config entries. I realized I don't have any Ubuntu hosts using Nginx, and that's probably why I've never fixed the config path behavior for Deb/Ubuntu (I use CentOS mainly, for production servers).

See #17 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants