Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Fedora 30 #86

Merged
merged 8 commits into from
Sep 17, 2019
Merged

Add support for Fedora 30 #86

merged 8 commits into from
Sep 17, 2019

Conversation

mikedep333
Copy link
Contributor

Requires #53 first.

@mikedep333 mikedep333 changed the title Fedora 30 Add support for Fedora 30 Aug 2, 2019
geerlingguy
geerlingguy requested changes Aug 5, 2019
View reviewed changes
Copy link
Owner

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review comments—additionally, if you could modify .travis.yml and add fedora30 to the test suite, that would be helpful in making sure the changes work and continue to work on Fedora 30 :)

meta/main.yml Show resolved Hide resolved
tasks/variables.yml Outdated Show resolved Hide resolved
vars/Fedora-27.yml Outdated Show resolved Hide resolved
vars/Fedora-28.yml Outdated Show resolved Hide resolved
This was referenced Aug 5, 2019
Closed
Closed
@mikedep333
Remove support for EOL Fedora 27 & 28
a7b553a 
Also properly list support for Fedora 30, and improve
formatting in a when condition.

This addresses comments in PR86:
geerlingguy#86
@mikedep333
Add fedora 29 to the test suite
536f4b9 
I am not adding Fedora 30 because there is no image for it, only:
docker.io/geerlingguy/docker-fedora29-ansible
@mikedep333
Copy link
Contributor Author

Please see review comments—additionally, if you could modify .travis.yml and add fedora30 to the test suite, that would be helpful in making sure the changes work and continue to work on Fedora 30 :)

Done the best I could. It looks like you only have an image for Fedora 29.

@mikedep333
Add Fedora 30 to the test suite
0020e63 
`podman search` wasn't seeing the image, but the image exists:
https://hub.docker.com/r/geerlingguy/docker-fedora30-ansible
@mikedep333
Copy link
Contributor Author

Please see review comments—additionally, if you could modify .travis.yml and add fedora30 to the test suite, that would be helpful in making sure the changes work and continue to work on Fedora 30 :)

I added this after all. Sorry for the earlier confusion.

@mikedep333 mikedep333 force-pushed the fedora-30 branch 4 times, most recently from 4679098 to d0273ec Compare August 7, 2019 15:39
@mikedep333
Fedora: Use python2-psycopg2 or python3-psycopg2
18be7cc 
"python-psycopg2" is replaced by python2-psycopg2, and the
verification task will fail.

EL8 will need this also
@mikedep333
Fix CI on Fedora 30 containers
185f7ba 
by forcing the use of the C.UTF-8 locale, which is all they have
installed by default
@mikedep333
Fix CI on Fedora 30 containers again
2fbc87c 
By not causing the /usr/bin/python symlink to be installed
Otherwise, Ansible molecule converge would use python2, which
lacks python2-dnf.
@mikedep333
Copy link
Contributor Author

mikedep333 commented Sep 3, 2019 •
edited
Loading

@geerlingguy I worked on this about a month ago and my memory is rusty, but I believe I implemented all of your requested changes completely.

@lhoss
Copy link

lhoss commented Sep 13, 2019

All requested changes implemented and build is green , let's merge 👍
After that, I can rebase those changes onto #54, which I'm particularly interested in

@geerlingguy geerlingguy merged commit 531b23f into geerlingguy:master Sep 17, 2019
This was referenced Sep 17, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geerlingguy geerlingguy geerlingguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikedep333 @lhoss @geerlingguy @ehelms