This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
added postgres support #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Dec 22, 2017
defaults/main.yml
Outdated
| sonar_mysql_password: sonar | ||
| # The Database engine. | ||
| # possible values: postgres and mysql | ||
| sonar_database_engine: postgres |
There was a problem hiding this comment.
I think that the default database engine should be mysql to avoid regression.
There was a problem hiding this comment.
thanks for your recommendation. mysql wasn't working that's why I've changed the default to postgres.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was getting trouble to run this role on CentOS 7 with the latest version of MySQL and Sonar 6. Then I changed your role to enable PostgreSQL as alternative using your other role (
geerlingguy.postgresql). Unfortunately I couldn't write the test code yet, but I've been testing on my env using Vagrant and I was able to successfully provisioned Sonar 6.4 with PostgreSQL.Postgres is now the default option and could be change it to MySQL any time just editing the
sonar_database_engineproperty. All other database properties was changed tosonar_database_*prefix so the script could be agnostic to the database.Please, if you think that could be done in any other way, let me know. I'm quite a newbie on Ansible.
Would be great if you merge it into your repo so we could use it via ansible-glaxy platform.
Thanks!