Resolve an issue with the systemd/sysvinit ansible conflict #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there appears to be an issue with Ansible in which, if a service is already enabled with sysvinit, the service will not be enabled with Ansible. This appears to be the condition with this repository; likely, the upstream package is bringing in the sysvinit script (as it's not being deployed by ansible) and enabling it. This commit implements a workaround as documented ansible/ansible-modules-core#3764 (comment). While, confusingly, the package is "using" the sysvinit style service tool for enabling the service, systemd implements a compatibility layer that allows enabling it via this shim. This correctly enables the service. See ansible/ansible#22303 See geerlingguy/ansible-role-php@84ab337
tobiasdam
added a commit
to usableprivacy/upribox
that referenced
this pull request
Jul 11, 2017
- ansible service/systemd module fails to enable some services - ansible/ansible-modules-core#3764 - geerlingguy/ansible-role-varnish#65
tobiasdam
added a commit
to usableprivacy/upribox
that referenced
this pull request
Jul 14, 2017
- systemd module (and service module, which uses systemd module per deault) has a problem with sysvinit services - see: geerlingguy/ansible-role-varnish#65
geerlingguy
requested changes
Jul 17, 2017
tasks/main.yml
Outdated
| with_items: "{{ varnish_enabled_services | default([]) }}" | ||
| when: > | ||
| varnish_enabled_services and | ||
| (ansible_os_family == 'Debian' and ansible_distribution_release == "xenial") |
tasks/main.yml
Outdated
| use: "service" | ||
| with_items: "{{ varnish_enabled_services | default([]) }}" | ||
| when: > | ||
| varnish_enabled_services and |
There was a problem hiding this comment.
For compound when conditions, you can use the style:
when:
- varnish_enabled_services
- ansible_os_family == 'Debian' and ansible_distribution_release == "xenial"I just discovered this recently, and am trying to get all my roles to use that style for complex conditionals; can you update these to use that style too?
Recently, Ansible introduced the capability to sum "when" conditions as
a yaml list (something like a json array). When formatted thusly:
when:
- foo == "bar"
- baz == "herp"
All conditionals are logically "and"ed together.
See http://docs.ansible.com/ansible/playbooks_conditionals.html#the-when-statement
Further, a line break was added to the bottom of this file.
geerlingguy
requested changes
Jul 23, 2017
| name: "{{ item }}" | ||
| state: started | ||
| enabled: yes | ||
| use: "service" |
There was a problem hiding this comment.
Another question here—isn't this task the exact same as the task above? I don't see why we'd need to have two tasks that do the exact same thing, but one for Xenial, and another for all other versions...
There was a problem hiding this comment.
ehhrm good catch. The initial one shouldn't use service -- instead, it should just use the Ansible default init system, in case the shim for sysvinit disappears at some point. I'll fix that up.
Previous work implemented a workaround for an ansible issue in which, in some cases, Ansible would not detect correctly whether a service is enabled. However, the author inadvertently committed a change to both tasks. This commit removes the change to the original task such that it will use the ansible service auto-dectection, and not sysvinit
|
fixed. Not tested -- I have no way of testing taht change anyways; it's non-xenial specific. I gather CI should pick it up? |
|
Yep, CI tests look good. Thanks! |
stefanodallapalma
added a commit
to stefanodallapalma/radon-repository-miner-testing
that referenced
this pull request
Jun 1, 2021
- ansible service/systemd module fails to enable some services - ansible/ansible-modules-core#3764 - geerlingguy/ansible-role-varnish#65 From usableprivacy/upribox@7836e5a
stefanodallapalma
added a commit
to stefanodallapalma/radon-repository-miner-testing
that referenced
this pull request
Jun 1, 2021
- ansible service/systemd module fails to enable some services - ansible/ansible-modules-core#3764 - geerlingguy/ansible-role-varnish#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there appears to be an issue with Ansible in which, if a
service is already enabled with sysvinit, the service will not be
enabled with Ansible. This appears to be the condition with this
repository; likely, the upstream package is bringing in the sysvinit
script (as it's not being deployed by ansible) and enabling it.
This commit implements a workaround as documented
ansible/ansible-modules-core#3764 (comment).
While, confusingly, the package is "using" the sysvinit style service
tool for enabling the service, systemd implements a compatibility layer
that allows enabling it via this shim. This correctly enables the
service.
See ansible/ansible#22303
See geerlingguy/ansible-role-php@84ab337