This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Issue #1068: Add php-yaml as a default php package #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good enough to me. I won't have time to test locally today, so if you get a chance let me know! |
|
Travis to the rescue! https://travis-ci.org/geerlingguy/drupal-vm/builds/186236162 (rebased away 5634f00) Worked on Ubuntu 16.04 and Centos7 with all php versions, with the exception of PHP 5.5 on Ubuntu. Looks like ondrej might have finally removed it https://travis-ci.org/geerlingguy/drupal-vm/jobs/186236165#L666. RTBM |
|
PHP 5.5 isn't officially supported by Drupal VM anymore (nor is it supported by PHP :D), so that's not an issue I care to deal with. Ship it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still entirely untested. Hopefully I'll get time to locally test it later today.