Set ssh_home as default pwd for SSH. #665
Conversation
| @@ -271,3 +271,4 @@ selenium_version: 2.46.0 | |||
| # Other configuration. | |||
| dashboard_install_dir: /var/www/dashboard | |||
| known_hosts_path: ~/.ssh/known_hosts | |||
| ssh_home: "{{ drupal_core_path }}" | |||
There was a problem hiding this comment.
Might the word "home" be confused with the path /home/? Perhaps this should be ssh_dir or ssh_path or ssh_dest?
EDIT: Unless this just a convention that I'm unaware of (likely!).
There was a problem hiding this comment.
@danbohea - haha - I struggled with the naming of this too! + it's not a convention.
Couldn't find a standard name so since by default SSH connections drop you in the users home dir, this configures the SSH home dir.
|
+1 for this. I just tested it out, and it works great. |
|
I like it too. Need to poke and prod it a tiny bit more, but one thing—I think it would be best to default to the normal .ssh dir ( |
|
@geerlingguy how about we just don't set a default and comment it out in |
thom8
force-pushed
the
ssh_home
branch
3 times, most recently
from
aa45464
to
5eecf66
Compare
| @@ -271,3 +271,4 @@ selenium_version: 2.46.0 | |||
| # Other configuration. | |||
| dashboard_install_dir: /var/www/dashboard | |||
| known_hosts_path: ~/.ssh/known_hosts | |||
| #ssh_home: "{{ drupal_core_path }}" | |||
There was a problem hiding this comment.
Commented out var in example.config.yml
|
D'oh, just noticed this PR has a conflict. Would you mind rebasing? |
|
@geerlingguy all done :) |
|
Changed milestone. Small/non-breaking enough that it can go into a patch release instead of full version bump. |
cd to
drupal_core_pathwhen SSHing to the VM. #661*note: this will be ignored if not set and fail gracefully if the path doesn't exist.