This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Adds optional defaults for php-fpm user & group. #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates default.config.yml to include a stub for defining the user that php-fpm runs as. See geerlingguy#781
Add group.
Bump version for php role so that geerlingguy/ansible-role-php#128 gets in.
| @@ -230,6 +230,11 @@ php_max_input_vars: "4000" | |||
| php_enable_php_fpm: true | |||
| php_fpm_listen: "127.0.0.1:9000" | |||
|
|
|||
| # If you want to run php-fpm as a user/group other than your OS's default user, | |||
There was a problem hiding this comment.
Instead of adding in this file, can you just add a note on this docs page (http://docs.drupalvm.com/en/latest/other/webservers/#using-nginx) mentioning these two variables and how to set them if switching to nginx? Since it's a smaller use case (at least at this point in time), I'd rather not add the four lines to default.config.yml.
Updates docs to reflect php-fpm user/group variables.
|
@geerlingguy, good call. Added some explanation to webservers.md (http://docs.drupalvm.com/en/latest/other/webservers/#using-nginx) and reverted changes to default.config.yml. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781 which is solved upstream but not yet referenced in requirements. Also adds an optional user/group param for php-fpm.