Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Issue #455: Add docs on environment specific configs #997

Merged
merged 1 commit into from Nov 17, 2016

Conversation

oxyc
Copy link
Collaborator

@oxyc oxyc commented Nov 16, 2016

A first draft of the functionality.

@oxyc
Copy link
Collaborator Author

oxyc commented Nov 16, 2016

I avoided giving specific suggestions as I'm not entirely sure what workflow we should be recommending.

Personally I would not entirely trust the environment variable and would instead have the security hardening configurations in config.yml while I override them with development tools in vagrant.config.yml. This way a production environment will never be provisioned with development tools even if I make a typo in the command.

@geerlingguy
Copy link
Owner

That's... a good point. Do we want to update the docs and recommend cloning default.config.yml to vagrant.config.yml instead of config.yml? Then in the docs we can say "if you consider using Drupal VM for production, you should set the secure overrides in config.yml and customize your local environment using vagrant.config.yml and production-specific overrides in prod.config.yml... something along those lines?

@oxyc
Copy link
Collaborator Author

oxyc commented Nov 16, 2016

Do we want to update the docs and recommend cloning default.config.yml to vagrant.config.yml instead of config.yml

You mean in README, all docs, etc?

@geerlingguy
Copy link
Owner

@oxyc - Yeah, maybe... though it might be a bit heavy handed. If Drupal VM becomes used more for multiple environment configuration (e.g. prod, stage, local), then using config this way is a little more correct.

But for the majority use case, currently just mentioning config.yml seems to be the simplest/least confusing. So I guess I just convinced myself to not recommend changing things up right now :D

@geerlingguy
Copy link
Owner

@oxyc - Can you also update the README in the prod directory to point to the docs page instead of having duplicated info? Just have the note about 'security is your responsibility', then direct people to the docs URL for more information.

@oxyc
Copy link
Collaborator Author

oxyc commented Nov 16, 2016

@geerlingguy you want me to move over all the docs from the README? Not much duplicate at the moment.

@geerlingguy
Copy link
Owner

Yeah.

@geerlingguy geerlingguy merged commit 5e4dee8 into geerlingguy:master Nov 17, 2016
@geerlingguy
Copy link
Owner

This is fine for now... we can iterate on it later :)

@oxyc oxyc deleted the env-config-docs branch April 24, 2017 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants