Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyuv >= 1.0.0 has 'getaddrinfo()' in 'dns' module #15

Merged
merged 3 commits into from
Dec 22, 2014

Conversation

Ed-von-Schleck
Copy link

From the first stable version on, pyuv has moved the 'getaddrinfo()' function from the 'util' module to the 'dns' module. This patch reflects this change.

If wanted for, I could modify it to fall back to 'util' when an import error occurs (just to preserve backwards compatibility), though I'd rather not.

@saghul
Copy link

saghul commented Dec 22, 2014

getnameinfo, defined just below, was moved in the same way. FWIW, I'd go for requiring pyuv >- 1.0.0, since that will be supported long term with backwards compatible API changes.

@Ed-von-Schleck
Copy link
Author

Thanks; I added this one as well.

@saghul
Copy link

saghul commented Dec 22, 2014

Maybe you could add another commit fixing the dependency here: https://github.com/geertj/gruvi/blob/master/requirements.txt

Also, install via pip instead of github download
@Ed-von-Schleck
Copy link
Author

Thanks again; I removed the direct github download as well in favour of using pypi.

@saghul
Copy link

saghul commented Dec 22, 2014

LGTM, but this is @geertj's project :-)

PS: The travis failure seems unrelated, FWIW.

@geertj
Copy link
Owner

geertj commented Dec 22, 2014

Thanks @Ed-von-Schleck and @saghul! The Travis error appears related to the SSL changes in 2.7.9, not to this commit. Looking into it now.

@geertj
Copy link
Owner

geertj commented Dec 22, 2014

The patch is good. The test failure is indeed an issue with the SSL changes in 2.7.9. Will fix those later tonight.

geertj added a commit that referenced this pull request Dec 22, 2014
pyuv >= 1.0.0 has 'getaddrinfo()' in 'dns' module
@geertj geertj merged commit e42135d into geertj:master Dec 22, 2014
@geertj
Copy link
Owner

geertj commented Dec 23, 2014

SSL in 2.7.9 has been fixes as well (in 274a798)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants