Fix TypeError at import time

[rsommer]

Commit python/cpython@562385d introduced _METHODS_EXPECTING_BODY at module level in httplib.py. The code in gruvi.http failes at import time with TypeError: unhashable type: 'set' on python 2.7.10 which includes this commit. Ignoring _METHODS_EXPECTING_BODY in the loop fixes the error, but I'm not sure if it has any side effects. The proposed change is more an example than a real solution i think.

Python 2.7.10 (default, May 28 2015, 16:39:33) 
[GCC 4.9.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import gruvi
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "gruvi/__init__.py", line 37, in <module>
    from .http import *
  File "gruvi/http.py", line 78, in <module>
    if name.isupper() and value in http_client.responses:
TypeError: unhashable type: 'set'

[geertj]

Thnaks @rsommer! I would prefer the following patch that doesn't hardcode the attribute name:

diff --git a/gruvi/http.py b/gruvi/http.py
index b4bbc45..87bf36d 100644
--- a/gruvi/http.py
+++ b/gruvi/http.py
@@ -75,7 +75,9 @@ __all__ = ['HttpError', 'HttpRequest', 'HttpResponse', 'HttpProtocol',
 # Export some definitions from  http.client.
 for name in dir(http_client):
     value = getattr(http_client, name)
-    if name.isupper() and value in http_client.responses:
+    if not name.isupper() or not isinstance(value, int):
+        return
+    if value in http_client.responses:
         globals()[name] = value

 HTTP_PORT = http_client.HTTP_PORT

I don't have the Python version you mention. Can you check if this works?

[rsommer]

I think you meant to use continue, not return? Seems to works with continue ...

diff --git a/gruvi/http.py b/gruvi/http.py
index b4bbc45..4ce1246 100644
--- a/gruvi/http.py
+++ b/gruvi/http.py
@@ -75,7 +75,10 @@ __all__ = ['HttpError', 'HttpRequest', 'HttpResponse', 'HttpProtocol',
 # Export some definitions from  http.client.
 for name in dir(http_client):
     value = getattr(http_client, name)
-    if name.isupper() and value in http_client.responses:
+    if not name.isupper() or not isinstance(value, int):
+        continue
+
+    if value in http_client.responses:
         globals()[name] = value

 HTTP_PORT = http_client.HTTP_PORT

[geertj]

arg.. Yes sorry, that needs to be continue :)

[geertj]

Fixed by 5c3a741.

[geertj]

@rsommer thanks!