Skip to content

Commit

Permalink
Fix urlresolvers deprecation in Django 1.11 (#210)
Browse files Browse the repository at this point in the history
  • Loading branch information
alin23 authored and f1nality committed Apr 29, 2017
1 parent 6875fd4 commit 4028604
Show file tree
Hide file tree
Showing 12 changed files with 60 additions and 14 deletions.
6 changes: 5 additions & 1 deletion jet/dashboard/dashboard.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
from importlib import import_module
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.template.loader import render_to_string
from jet.dashboard import modules
from jet.dashboard.models import UserDashboardModule
Expand Down
6 changes: 5 additions & 1 deletion jet/dashboard/dashboard_modules/google_analytics.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
import datetime
import json
from django import forms
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.forms import Widget
from django.utils import formats
from django.utils.html import format_html
Expand Down
6 changes: 5 additions & 1 deletion jet/dashboard/dashboard_modules/google_analytics_views.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.conf.urls import url
from django.contrib import messages
from django.shortcuts import redirect
Expand Down
6 changes: 5 additions & 1 deletion jet/dashboard/dashboard_modules/yandex_metrika.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
import datetime
import json
from django import forms
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.forms import Widget
from django.utils import formats
from django.utils.html import format_html
Expand Down
6 changes: 5 additions & 1 deletion jet/dashboard/dashboard_modules/yandex_metrika_views.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
from django.conf.urls import url
from django.contrib import messages
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.http import HttpResponse
from django.shortcuts import redirect
from jet.dashboard.dashboard_modules.yandex_metrika import YandexMetrikaClient
Expand Down
6 changes: 5 additions & 1 deletion jet/dashboard/views.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
from django.contrib import messages
from django.core.exceptions import ValidationError
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.forms.formsets import formset_factory
from django.http import HttpResponseRedirect
from django.views.decorators.http import require_POST, require_GET
Expand Down
5 changes: 4 additions & 1 deletion jet/filters.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
from django.contrib.admin import RelatedFieldListFilter
from django.utils.encoding import smart_text
from django.utils.html import format_html
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

try:
from django.contrib.admin.utils import get_model_from_relation
Expand Down
6 changes: 5 additions & 1 deletion jet/templatetags/jet_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
import json
import os
from django import template
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.forms import CheckboxInput, ModelChoiceField, Select, ModelMultipleChoiceField, SelectMultiple
from django.contrib.admin.widgets import RelatedFieldWidgetWrapper
from django.utils.formats import get_format
Expand Down
6 changes: 5 additions & 1 deletion jet/tests/test_dashboard.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
from django.contrib.auth.models import User
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.test import TestCase, Client
from jet.dashboard.dashboard import Dashboard
from jet.dashboard.modules import LinkList, RecentActions
Expand Down
6 changes: 5 additions & 1 deletion jet/tests/test_tags.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
from django import forms
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.test import TestCase
from jet.templatetags.jet_tags import jet_select2_lookups, jet_next_object, jet_previous_object
from jet.tests.models import TestModel, SearchableTestModel
Expand Down
6 changes: 5 additions & 1 deletion jet/tests/test_views.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import json
from django.contrib.auth.models import User
from django.core.urlresolvers import reverse
try:
from django.core.urlresolvers import reverse
except ImportError: # Django 1.11
from django.urls import reverse

from django.test import TestCase, Client
from jet.dashboard.modules import LinkList
from jet.models import Bookmark
Expand Down
9 changes: 6 additions & 3 deletions jet/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,18 @@
pass
from django.core.serializers.json import DjangoJSONEncoder
from django.http import HttpResponse
from django.core.urlresolvers import reverse, resolve, NoReverseMatch
try:
from django.core.urlresolvers import reverse, resolve, NoReverseMatch
except ImportError: # Django 1.11
from django.urls import reverse, resolve, NoReverseMatch

from django.contrib.admin import AdminSite
from django.utils.encoding import smart_text
from django.utils.text import capfirst
from django.contrib import messages
from django.utils.encoding import force_text
from django.utils.functional import Promise
from django.contrib.admin.options import IncorrectLookupParameters
from django.core import urlresolvers
from django.contrib import admin
from django.utils.translation import ugettext_lazy as _
from django.utils.text import slugify
Expand Down Expand Up @@ -178,7 +181,7 @@ def get_model_queryset(admin_site, model, request, preserved_filters=None):
model_admin = admin_site._registry.get(model)

try:
changelist_url = urlresolvers.reverse('%s:%s_%s_changelist' % (
changelist_url = reverse('%s:%s_%s_changelist' % (
admin_site.name,
model._meta.app_label,
model._meta.model_name
Expand Down

0 comments on commit 4028604

Please sign in to comment.