Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://jet.geex-arts.com/ping.gif #260

Open
fannigurt opened this issue Oct 27, 2017 · 13 comments
Open

https://jet.geex-arts.com/ping.gif #260

fannigurt opened this issue Oct 27, 2017 · 13 comments

Comments

@fannigurt
Copy link

Guys, what is it and why for? =)

@SalahAdDin
Copy link
Contributor

Where did you find it?

@fannigurt
Copy link
Author

fannigurt commented Oct 29, 2017

jet/static/jet/js/src/layout-updaters/branding.js:29

$(document).ready(function() {
$('#branding').each(function() {
new BrandingUpdater($(this)).run();
});
if ($('body.login').length != 0) {
$('').attr('src', '//jet.geex-arts.com/ping.gif');
}
});

seem like it's safely

but if I've secured my admin panel link - it's unsecured with such request =)

@SalahAdDin
Copy link
Contributor

It is a point, i don't know which is his utility.

@fannigurt
Copy link
Author

huh? what do you mean?

@SalahAdDin
Copy link
Contributor

yep, the utility for this gif.

@tityrus
Copy link

tityrus commented Nov 8, 2017

It's to ping home, probably done by the author for the purpose of statistics, to know how many projects are using Django Jet, and also to keep some control on who is paying or not paying for the commercial license.

Anyway, I don't think it should be there.

@fannigurt
Copy link
Author

clear. we can close this issue

@SalahAdDin
Copy link
Contributor

@Jorisvd How do you knotw this?

Thanks!

@tityrus
Copy link

tityrus commented Nov 10, 2017

Correction, I don't know that for sure.
However, what other purpose could it have?

@fannigurt
Copy link
Author

I can just comment it.
I don't want to have external GET from my secure address of the admin panel.
Hope the author won't be against such step.

@SalahAdDin
Copy link
Contributor

@f1nality

@ferdynice
Copy link

Duplicate of #235

I think this ping.gif should be removed.

@REDAOUIAahmed
Copy link

Flow to Arts.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants