Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing/placeholder icons pose problems for static file serving #58

Closed
philipbelesky opened this issue Mar 15, 2016 · 2 comments
Closed
Milestone

Comments

@philipbelesky
Copy link

There are a few a couple of icons that are loaded as such:

<img src="{% static "admin/img/icon-unknown.gif" %}" ..... />

The CSS and JS then matches that src path and then replaces the icon in many circumstances. However, these icons have been removed or change to be SVG files as of Django 1.9 and can throw exceptions depending in some circumstances (for me using whitenoise and with debug off).

I can probably do a pull request to fix that — in which case should I amend #45 to create a more generic "django 1.9 or above" tag and do a bunch of if/elses? Is there a more elegant solution?

@SalahAdDin
Copy link
Contributor

👍

@f1nality
Copy link
Contributor

Fixed in 0.9.0 by extending selectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants