Remove reference to redundant ie.css file removed in Django 1.9.2 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I think older versions of Django should be also supported, so some if case should be added. |
IE.css was removed as of 1.9.2; the new template tag checks against this version before writing the link to it into the template. Signed-off-by: Philip Belesky <contact@philipbelesky.com>
Signed-off-by: Philip Belesky <contact@philipbelesky.com>
|
Sure, have added in a conditional check — does that do the trick? |
|
Thanks! I'll merge it to 0.1.5 |
|
I decided not to include IE6 and IE7 support as Django did, because it will strange to include this support for new Django and not old. So your first solution was applied in 0.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Django 1.9.2 the ie.css file is removed as IE 6 and 7 have reached EOL. I wasn't sure how to keep the file around based on current Django version, although if Django proper has dropped IE6/7 it may be worth considering doing the same. Having a reference to a file that no longer exists also breaks some static file implementations.