Skip to content

Commit

Permalink
Merge branch 'fix/#305' into #314
Browse files Browse the repository at this point in the history
  • Loading branch information
Schille committed Jan 13, 2023
2 parents a2a6e00 + 1655b94 commit c919793
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion client/gefyra/local/utils.py
Expand Up @@ -135,7 +135,7 @@ def handle_docker_run_container(
)


def get_connection_from_kubeconfig(kubeconfig: Optional[str]) -> Optional[str]:
def get_connection_from_kubeconfig(kubeconfig: Optional[str] = None) -> Optional[str]:
import yaml

if kubeconfig:
Expand Down
4 changes: 2 additions & 2 deletions client/tests/test_cli_utils.py
Expand Up @@ -7,13 +7,13 @@


@patch("kubernetes.config.kube_config.KUBE_CONFIG_DEFAULT_LOCATION", "/tmp/kube.yaml")
def test_get_connection_from_kubeconfig_no_connection():
def test_a_get_connection_from_kubeconfig_no_connection():
endpoint = get_connection_from_kubeconfig()
assert endpoint is None


@patch("kubernetes.config.kube_config.KUBE_CONFIG_DEFAULT_LOCATION", "/tmp/kube.yaml")
def test_get_connection_from_kubeconfig_connection():
def test_b_get_connection_from_kubeconfig_connection():
data = {
"current-context": "fake",
"contexts": [
Expand Down

0 comments on commit c919793

Please sign in to comment.