Use INWX Name server to check old ip #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strubbl
added a commit
to Strubbl/Bash-INWX-DynDNS
that referenced
this pull request
Oct 29, 2021
This commit fixes a race condition, where only the first inwx id of an array of multiple ids gets updated. The section to save the old v4 and v6 address is moved out of the for loop in order to have these variables saved globally. This way we have still the old ip address saved, even in the second run of the for loop. This commit is a similar solution to the more complex solutions in gehaxelt#23 and gehaxelt#25
This was referenced Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple IDs for either v4 or v6, only one ID gets updated. This is due to the used caching of the old ip address which gets updated once the first ID has been updated leading to "no changes" for all subsequent IDs.
To fix this I changed the script to check the external NS of INWX for the old ip to determine if an update is required.
Therefore, two new parameters are required: