Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to PyPI #23

Closed
geigerzaehler opened this issue Nov 4, 2018 · 6 comments
Closed

Publish to PyPI #23

geigerzaehler opened this issue Nov 4, 2018 · 6 comments

Comments

@geigerzaehler
Copy link
Owner

Publish this code as a package to PyPI. Setup CI to do auto-publishing.

@wisp3rwind
Copy link
Collaborator

From my side, now could be the time :) All changes from my fork will be backported when #26 and #27 are merged.

Thanks again for all of the reviews and the nagging about adding tests, the quality of all of those patches has certainly improved a lot!

@wisp3rwind
Copy link
Collaborator

@Profpatsch (I hope you're the one to bug, or at least can ping someone else), I just noticed that you switched the NixOS package to my repository. Would you please switch it back to this repo soon-ish? The code here is better tested, and #27 is handled less elegantly on my fork since it requires changes to the configuration. The latter are undocumented, but whoever has bothered to take a look at the code might end up with (harmless) unused config entries.

@geigerzaehler
Copy link
Owner Author

It on PyPI now.

@wisp3rwind
Copy link
Collaborator

@aszlig: see above, I hadn't noticed that the maintainers for the beets package changed in the meantime. Thanks!

@aszlig
Copy link

aszlig commented Nov 29, 2018

@wisp3rwind: Thanks for the heads-up, will change that. Yes, @Profpatsch has removed himself from the main beets package in NixOS/nixpkgs@2922bee, but when it comes to beets-alternatives I was the one introducing it in nixpkgs and also maintaining it since.

@aszlig
Copy link

aszlig commented Nov 29, 2018

@wisp3rwind: See NixOS/nixpkgs@887ae75. I also added myself as the maintainer in NixOS/nixpkgs@bef2a43 to avoid such confusion in the future. Thanks :-)

aszlig added a commit to NixOS/nixpkgs that referenced this issue Nov 29, 2018
This introduces the following upstream changes:

  * The package is now on PyPI
  * Require at least beets v1.4.7
  * Update album art in alternatives when it changes
  * Python 3 support (Python 2.7 continues to be supported)
  * Support the format aliases defined by the convert plugin ('wma' and
    'vorbis' with current beets)
  * Bugfix: Explicitly write tags after encoding instead of relying on
            the encoder to do so
  * Bugfix: If the formats config option is modified, don't move files
            if the extension would change, but re-encode

I updated this because I was pinged by @wisp3rwind about moving back to
@geigerzaehler's repository at [1].

This is what @wisp3rwind wrote in the comment[2] (which was originally
directed to @Profpatsch):

  (I hope you're the one to bug, or at least can ping someone else), I
  just noticed that you switched the NixOS package to my repository.
  Would you please switch it back to this repo soon-ish? The code here
  is better tested, and [3] is handled less elegantly on my fork since
  it requires changes to the configuration. The latter are undocumented,
  but whoever has bothered to take a look at the code might end up with
  (harmless) unused config entries.

So in essence we're now back to the original upstream repository again,
which I changed to @wisp3rwind's fork in 29e8924
because it fixed issues with Python 3.

Stripping the long_description from setup.py also doesn't seem to be
required anymore, but I didn't investigate why (might be because either
our Python tooling now sets a default language or the README simply no
longer has non-ASCII characters).

[1]: https://github.com/geigerzaehler/beets-alternatives
[2]: geigerzaehler/beets-alternatives#23
[3]: geigerzaehler/beets-alternatives#27

Signed-off-by: aszlig <aszlig@nix.build>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants