-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to PyPI #23
Comments
@Profpatsch (I hope you're the one to bug, or at least can ping someone else), I just noticed that you switched the NixOS package to my repository. Would you please switch it back to this repo soon-ish? The code here is better tested, and #27 is handled less elegantly on my fork since it requires changes to the configuration. The latter are undocumented, but whoever has bothered to take a look at the code might end up with (harmless) unused config entries. |
It on PyPI now. |
@aszlig: see above, I hadn't noticed that the maintainers for the |
@wisp3rwind: Thanks for the heads-up, will change that. Yes, @Profpatsch has removed himself from the main beets package in NixOS/nixpkgs@2922bee, but when it comes to beets-alternatives I was the one introducing it in nixpkgs and also maintaining it since. |
@wisp3rwind: See NixOS/nixpkgs@887ae75. I also added myself as the maintainer in NixOS/nixpkgs@bef2a43 to avoid such confusion in the future. Thanks :-) |
This introduces the following upstream changes: * The package is now on PyPI * Require at least beets v1.4.7 * Update album art in alternatives when it changes * Python 3 support (Python 2.7 continues to be supported) * Support the format aliases defined by the convert plugin ('wma' and 'vorbis' with current beets) * Bugfix: Explicitly write tags after encoding instead of relying on the encoder to do so * Bugfix: If the formats config option is modified, don't move files if the extension would change, but re-encode I updated this because I was pinged by @wisp3rwind about moving back to @geigerzaehler's repository at [1]. This is what @wisp3rwind wrote in the comment[2] (which was originally directed to @Profpatsch): (I hope you're the one to bug, or at least can ping someone else), I just noticed that you switched the NixOS package to my repository. Would you please switch it back to this repo soon-ish? The code here is better tested, and [3] is handled less elegantly on my fork since it requires changes to the configuration. The latter are undocumented, but whoever has bothered to take a look at the code might end up with (harmless) unused config entries. So in essence we're now back to the original upstream repository again, which I changed to @wisp3rwind's fork in 29e8924 because it fixed issues with Python 3. Stripping the long_description from setup.py also doesn't seem to be required anymore, but I didn't investigate why (might be because either our Python tooling now sets a default language or the README simply no longer has non-ASCII characters). [1]: https://github.com/geigerzaehler/beets-alternatives [2]: geigerzaehler/beets-alternatives#23 [3]: geigerzaehler/beets-alternatives#27 Signed-off-by: aszlig <aszlig@nix.build>
Publish this code as a package to PyPI. Setup CI to do auto-publishing.
The text was updated successfully, but these errors were encountered: