Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crashing 'beet completion' #39

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Avoid crashing 'beet completion' #39

merged 1 commit into from
Sep 18, 2019

Conversation

geigerzaehler
Copy link
Owner

Add the _get_all_options() method to the argument parser so that beet completion does not throw an error anymore.

Fixes #38

@geigerzaehler geigerzaehler mentioned this pull request Sep 15, 2019
Closed
wisp3rwind
wisp3rwind requested changes Sep 17, 2019
View reviewed changes
Copy link
Collaborator

@wisp3rwind wisp3rwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the flake8 issue, LGTM 🎉 The build failure on Python 3.8 appears to be spurious: the Python archive couln't be fetched in one case, and the remaining 3.8 runs succeeded.

beetsplug/alternatives.py Outdated Show resolved Hide resolved
beetsplug/alternatives.py Show resolved Hide resolved
Avoid crashing 'beet completion'
a01d5d6 
Add the `_get_all_options()` method to the argument parser so that `beet
completion` does not throw an error anymore.

Fixes #38
@wisp3rwind wisp3rwind merged commit 1bc8752 into master Sep 18, 2019
@geigerzaehler geigerzaehler deleted the completion-fix branch September 18, 2019 17:28
@geigerzaehler geigerzaehler mentioned this pull request Sep 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisp3rwind wisp3rwind wisp3rwind requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beet completion crashes with lastest git
2 participants
@geigerzaehler @wisp3rwind