Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize project tools #70

Merged
merged 7 commits into from May 2, 2023
Merged

Modernize project tools #70

merged 7 commits into from May 2, 2023

Conversation

geigerzaehler
Copy link
Owner

Modernize the tools and dependencies this project uses

  • Require Python ^3.8 and beets >= 1.6
  • Use Poetry
  • Use black and isort
  • Use Github Actions

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
@geigerzaehler geigerzaehler linked an issue Apr 29, 2023 that may be closed by this pull request
@geigerzaehler geigerzaehler force-pushed the g/modernize branch 2 times, most recently from 7c17255 to 12eeaee Compare April 29, 2023 10:02
@wisp3rwind
Copy link
Collaborator

This is great!

Two small points:

  • I think it would be good to keep using a test matrix with a few Python versions (oldest supported, latest stable, dev). In beets itself, this has been helpful to catch some errors due to deprecations or beets' use of Python implementation details (probably not so relevant for beets-alternatives, but who knows.)
  • I guess the "Add black and isort to toolchain" commit has no code changes other than applying those tools?

@wisp3rwind
Copy link
Collaborator

Oh, and let's keep #55 open as a reminder to actually remove all Python 2 compatibility code (in particular, the six dependency).

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
@geigerzaehler
Copy link
Owner Author

Yes, that’s correct.

I think it would be good to keep using a test matrix with a few Python versions

Done

Oh, and let's keep #55 open as a reminder to actually remove all Python 2 compatibility code (in particular, the six dependency).

I’ll close the issue and open a separate one to remove Python 2 compatibility code.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Copy link
Collaborator

@wisp3rwind wisp3rwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wisp3rwind wisp3rwind merged commit a69117c into master May 2, 2023
8 of 9 checks passed
@wisp3rwind wisp3rwind deleted the g/modernize branch May 2, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 2.7 support
2 participants