SetAttrs should take Elem as argument

[pawelkaczor]

No description provided.

[geirolz]

Hi @pawelkaczor thanks for your contribution! Let me check your proposal, could you please add more details and examples(so we can add also some documentation about it) in the meanwhile?

[geirolz]

Add documentation

[pawelkaczor]

Hi @geirolz. I would rather treat this issue as a "missing feature". Imagine you just want to update a value of an existing attribute (like value = value + 1). How can I accomplish this with advxml?

[pawelkaczor]

Concrete example:

  private val dataAgeAttrAddition: ComposableXmlModifier =
    SetAttr(attrs => {
      val age = DataAge(Instant.parse(attrs \@ "CREATED_AT"), clock.instant)
      k"DATA_AGE" := age.asString
    })

[geirolz]

Hi @geirolz. I would rather treat this issue as a "missing feature". Imagine you just want to update a value of an existing attribute (like value = value + 1). How can I accomplish this with advxml?

Good point, I agree. It is achievable but with some workaround.
Does it introduce some breaking changes for the API? Sorry I have no time to see the code now, I will this evening

If it does we can introduce something new like UpdateAttrs action

[pawelkaczor]

A new constructor method has been added to the API. This is not a breaking change.

[codecov]

Codecov Report

Merging #199 (aa296c6) into master (bde7c45) will decrease coverage by 0.31%.
The diff coverage is 50.00%.

❗ Current head aa296c6 differs from pull request most recent head 1f6d1bf. Consider uploading reports for the commit 1f6d1bf to get more accurate results

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   99.42%   99.11%   -0.32%     
==========================================
  Files          21       21              
  Lines         347      338       -9     
==========================================
- Hits          345      335      -10     
- Misses          2        3       +1     

Impacted Files	Coverage Δ
.../scala/advxml/instances/AllTransforInstances.scala	96.96% <50.00%> (-3.04%)	⬇️
...s/core/src/main/scala/advxml/core/data/Value.scala	96.29% <0.00%> (-0.14%)	⬇️
...ore/src/main/scala/advxml/core/data/KeyValue.scala	100.00% <0.00%> (ø)
...e/src/main/scala/advxml/syntax/AllDataSyntax.scala	100.00% <0.00%> (ø)
...src/main/scala/advxml/core/transform/XmlZoom.scala	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde7c45...1f6d1bf. Read the comment docs.

[geirolz]

@pawelkaczor if you can add some tests for this then we can merge it!

Please check XmlTransformationSpec, TransformXmlRuleSyntaxTest and TransformModifiersTest

[pawelkaczor]

Done. Not sure if the test fails because of my change?

[pawelkaczor]

Looks like the tests were failing before my changes.

[geirolz]

Looks like the tests were failing before my changes.

Yes, no problem I'm going to fix it, one done I merge. Thanks again for the contribution!

[geirolz]

@pawelkaczor merged! Just added you as a contributor in the readme file, thanks again!