Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ref value to encoded JSON and XML #180

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add ref value to encoded JSON and XML #180

wants to merge 4 commits into from

Conversation

geirolz
Copy link
Owner

@geirolz geirolz commented Jun 4, 2023

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 4, 2023
View reviewed changes
project/ProjectDependencies.scala

object ProjectDependencies {

private val catsVersion = "2.9.0"
private val catsEffectVersion = "3.4.10"
private val circeVersion = "0.14.5"
private val catsXmlVersion = "0.0.9"
private val catsXmlVersion = "0.0.10"

Check notice

Code scanning / Scalastyle (reported by Codacy)

Field name does not match the regular expression '^[A-Z][A-Za-z0-9]*$'. Note

Field name does not match the regular expression '^[A-Z][A-Za-z0-9]*$'.
modules/cats-xml/src/test/scala/erules/cats/xml/report/XmlReportEncoderSpec.scala Outdated
@@ -47,7 +47,7 @@
<Verdict type="Allowed">
<EvaluatedRules>
<RuleResult>
<RuleInfo name="Check Y value" description="" targetInfo="">
<RuleInfo ref="5340595900475325933418219074917" name="Check Y value" description="" targetInfo="">

Check notice

Code scanning / Scalastyle (reported by Codacy)

Use correct indentation. Note

Use correct indentation.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 4, 2023
View reviewed changes
modules/cats-xml/README.md
@@ -113,7 +113,7 @@
// <Verdict type="Denied">
// <EvaluatedRules>
// <RuleResult>
// <RuleInfo name="Check UK citizenship" description="" targetInfo="citizenship">
// <RuleInfo ref="130951030448721307306845976060863283070036075973018254042724231716505479005503484356976" name="Check UK citizenship" description="" targetInfo="citizenship">

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 179 Warning

Expected: 80; Actual: 179
modules/cats-xml/README.md
@@ -127,7 +127,7 @@
// </Verdict>
// </RuleResult>
// <RuleResult>
// <RuleInfo name="Check Age >= 18" description="" targetInfo="age">
// <RuleInfo ref="6456384276212653871606686934193894105466714179028215653" name="Check Age >= 18" description="" targetInfo="age">

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 134 Warning

Expected: 80; Actual: 134
modules/cats-xml/README.md
@@ -55,7 +55,7 @@
.targetInfo("age")
.contramap(_.age)
)
// allPersonRules: NonEmptyList[PureRule[Person]] = NonEmptyList(RuleImpl(scala.Function1$$Lambda$11130/0x000000080284d2d8@51548dba,RuleInfo(Check UK citizenship,None,Some(citizenship))), RuleImpl(scala.Function1$$Lambda$11130/0x000000080284d2d8@1e2818b1,RuleInfo(Check Age >= 18,None,Some(age))))
// allPersonRules: NonEmptyList[PureRule[Person]] = NonEmptyList(RuleImpl(scala.Function1$$Lambda$13094/0x0000000802e2c000@70daf84e,RuleInfo(Check UK citizenship,None,Some(citizenship))), RuleImpl(scala.Function1$$Lambda$13094/0x0000000802e2c000@3e336048,RuleInfo(Check Age >= 18,None,Some(age))))

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 297 Warning

Expected: 80; Actual: 297
modules/circe/README.md
@@ -55,7 +55,7 @@
.targetInfo("age")
.contramap(_.age)
)
// allPersonRules: NonEmptyList[PureRule[Person]] = NonEmptyList(RuleImpl(scala.Function1$$Lambda$11130/0x000000080284d2d8@3d4c38ac,RuleInfo(Check UK citizenship,None,Some(citizenship))), RuleImpl(scala.Function1$$Lambda$11130/0x000000080284d2d8@158954df,RuleInfo(Check Age >= 18,None,Some(age))))
// allPersonRules: NonEmptyList[PureRule[Person]] = NonEmptyList(RuleImpl(scala.Function1$$Lambda$13094/0x0000000802e2c000@61347703,RuleInfo(Check UK citizenship,None,Some(citizenship))), RuleImpl(scala.Function1$$Lambda$13094/0x0000000802e2c000@226215ec,RuleInfo(Check Age >= 18,None,Some(age))))

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 297 Warning

Expected: 80; Actual: 297
README.md
@@ -81,7 +81,7 @@
.targetInfo("age")
.contramap(_.age)
)
// allPersonRules: NonEmptyList[PureRule[Person]] = NonEmptyList(RuleImpl(scala.Function1$$Lambda$11130/0x000000080284d2d8@eb0606d,RuleInfo(Check UK citizenship,None,Some(citizenship))), RuleImpl(scala.Function1$$Lambda$11130/0x000000080284d2d8@2b5de320,RuleInfo(Check Age >= 18,None,Some(age))))
// allPersonRules: NonEmptyList[PureRule[Person]] = NonEmptyList(RuleImpl(scala.Function1$$Lambda$13094/0x0000000802e2c000@42b306f2,RuleInfo(Check UK citizenship,None,Some(citizenship))), RuleImpl(scala.Function1$$Lambda$13094/0x0000000802e2c000@28926acd,RuleInfo(Check Age >= 18,None,Some(age))))

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 297 Warning

Expected: 80; Actual: 297
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2023
View reviewed changes
project/ProjectDependencies.scala

object ProjectDependencies {

private val catsVersion = "2.9.0"
private val catsEffectVersion = "3.4.10"
private val circeVersion = "0.14.5"
private val catsXmlVersion = "0.0.9"
private val catsXmlVersion = "0.0.10"

Check notice

Code scanning / Codacy-scalameta-pro (reported by Codacy)

Values should have minimum scope to avoid misuses. Note

catsXmlVersion should have a smaller scope by using private[this]
core/src/test/scala/erules/RuleRefSpec.scala
.withMinSuccessfulTests(2000)

property("RuleRef.fromString is unique for each string") {
val history: scala.collection.mutable.Map[String, RuleRef] = scala.collection.mutable.Map.empty

Check warning

Code scanning / Codacy-scalameta-pro (reported by Codacy)

Prefer using immutable collections. Warning

It's preferred to use immutable collections instead of mutable ones
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2023
View reviewed changes
core/src/test/scala/erules/RuleRefSpec.scala
@@ -0,0 +1,38 @@
package erules

Check notice

Code scanning / Scalastyle (reported by Codacy)

File must not end with newline character. Note

File must not end with newline character.
core/src/test/scala/erules/RuleRefSpec.scala
@@ -0,0 +1,38 @@
package erules

Check notice

Code scanning / Scalastyle (reported by Codacy)

Header does not match expected text. Note

Header does not match expected text.
core/src/test/scala/erules/RuleRefSpec.scala
override def scalaCheckTestParameters: Test.Parameters =
super.scalaCheckTestParameters
.withMinSize(100)
.withMinSuccessfulTests(2000)

Check notice

Code scanning / Scalastyle (reported by Codacy)

Use of a magic number. Note

Use of a magic number.
core/src/test/scala/erules/RuleRefSpec.scala
val history: scala.collection.mutable.Map[String, RuleRef] = scala.collection.mutable.Map.empty
forAll { (str: String) =>
val ref = RuleRef.fromString(str)
if (!history.contains(str))

Check notice

Code scanning / Scalastyle (reported by Codacy)

If block needs braces. Note

If block needs braces.
core/src/test/scala/erules/RuleRefSpec.scala

override def scalaCheckTestParameters: Test.Parameters =
super.scalaCheckTestParameters
.withMinSize(100)

Check notice

Code scanning / Scalastyle (reported by Codacy)

Use of a magic number. Note

Use of a magic number.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2023
View reviewed changes
modules/cats-xml/src/test/scala/erules/cats/xml/report/XmlReportEncoderSpec.scala
@@ -47,7 +47,7 @@
<Verdict type="Allowed">
<EvaluatedRules>
<RuleResult>
<RuleInfo name="Check Y value" description="" targetInfo="">
<RuleInfo ref="4857243675792529696" name="Check Y value" description="" targetInfo="">

Check notice

Code scanning / Scalastyle (reported by Codacy)

Use correct indentation. Note

Use correct indentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@geirolz