Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): hide item when unit size is 0 #280

Merged
merged 4 commits into from
Jun 20, 2020
Merged

feat(grid): hide item when unit size is 0 #280

merged 4 commits into from
Jun 20, 2020

Conversation

unix
Copy link
Member

@unix unix commented Jun 20, 2020

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

resolved #278

@unix unix self-assigned this Jun 20, 2020
@unix unix linked an issue Jun 20, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #280 into rc will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               rc     #280   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         186      186           
  Lines        2365     2366    +1     
  Branches      540      563   +23     
=======================================
+ Hits         2364     2365    +1     
  Misses          1        1           
Impacted Files Coverage Δ
components/grid/basic-item.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5be3a...ebd8d6c. Read the comment docs.

@unix unix merged commit a309b86 into geist-org:rc Jun 20, 2020
@unix unix deleted the grid branch June 20, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide grid when item value is 0
1 participant