This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Refactor backend fix #101
Merged
Refactor backend fix #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 4, 2020 12:25
|
|
…j-marowd into refactor_backend_fix
swaggerを元に戻した。
|
コメント全て読みました。ファイルの切り分けで何やってるかがスッキリしました |
|
|
reud
commented
Mar 14, 2020
| @@ -32,7 +32,7 @@ export const GetClassDataHandler = async ( | |||
| } catch (exception) { | |||
| console.log("class not found probably wrong or empty query"); | |||
| console.log(exception); | |||
| resp.sendStatus(404).send("Not Found"); | |||
| resp.sendStatus(404); | |||
There was a problem hiding this comment.
resp.sendStatus(404)で主にレスポンス送ってるのにさらに.send("Not Found");って書いてるのがダメだったぽいね！
一括で書き換えしてたので修正漏れていました。ありがとうございます！
| return; | ||
| } | ||
| resp.sendStatus(200).send(JSON.stringify(qss.data())); | ||
| resp.send(JSON.stringify(qss.data())); |
There was a problem hiding this comment.
@kanade9
この場合、ステータスコードって200になってる？
なるならそのままでおkですが、ならないなら
resp.status(200).send(JSON.stringify(qss.data()));
にする必要がありそうです。確認お願いします！
|
修正したのでマージします！！ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO